Add missing use function imports in NumericHelper by Copilot · Pull Request #157 · yiisoft/strings

Copilot · 2026-01-08T20:47:44Z

The trimDecimalZeros method uses rtrim, str_contains, and str_ends_with without importing them via use function statements, inconsistent with the file's existing style.

Changes:

Added use function rtrim;
Added use function str_contains;
Added use function str_ends_with;

All imports added in alphabetical order alongside existing function imports (lines 10-23).

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…s_with Co-authored-by: samdark <[email protected]>

Copilot · 2026-01-08T20:56:22Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/Seldaek/jsonlint/zipball/1748aaf847fc731cfad7725aec413ee46f0cc3a2
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/azjezz/psl/zipball/15153a64c9824335ce11654522e7d88de762d39e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/bamarni/composer-bin-plugin/zipball/e7ef9e012667327516c24e5fad9903a3bc91389d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/clue/reactphp-stdio/zipball/dfa6c378aabdff718202d4e2453f752c38ea3399
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/clue/reactphp-term/zipball/00f297dc597eaee2ebf98af8f27cca5d21d60fa3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/clue/reactphp-utf8/zipball/d5cd04d39cb5457aa5df830b7c4b301d2694217e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/doctrine/annotations/zipball/901c2ee5d26eb64ff43c47976e114bf00843acf7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/doctrine/lexer/zipball/31ad66abc0fc9e1a1f2d9bc6a42668d2fbbcd6dd
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/igorw/evenement/zipball/0a16b0d71ab13284339abb99d9d2bd813640efbc
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/jolicode/JoliNotif/zipball/7083df4c4dc614f20bf16dc3ad53f705460bd1dd
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/jolicode/php-os-helper/zipball/e71596ae67d477fe214a5908f5522b9e4d19fd37
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/maglnet/ComposerRequireChecker/zipball/c62d517ef5ac2d347dd9b3d02c1cc16c0f1091e2
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/cache/zipball/aa5030cfa5405eccfdcb1083ce040c2cb8d253bf
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpbench/container/zipball/0c7b2d36c1ea53fe27302fb8873ded7172047196
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpbench/phpbench/zipball/b641dde59d969ea42eed70a39f9b51950bc96878
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpstan/phpstan/zipball/9e800e6bee7d5bd02784d4c6069b48032d16224f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/reactphp/event-loop/zipball/ba276bda6083df7e0050fd9b33f66ad7a4ac747a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/reactphp/stream/zipball/1e5b0acb8fe55143b5b426817155190eb6f5b18d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/f0NVrl /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/rectorphp/rector/zipball/f7166355dcf47482f27be59169b0825995f51c7d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/revoltphp/event-loop/zipball/b6fc06dce8e9b523c9946138fa5e62181934f91c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/c34583b87e7b7a8055bf6c450c2c77ce32a24084
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/code-unit-reverse-lookup/zipball/5e3a687f7d8ae33fb362c5c0743794bbb2420a1d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/code-unit/zipball/a81fee9eef0b7a76af11d121767abc44c104e503
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/comparator/zipball/e8e53097718d2b53cfb2aa859b06a41abf58c62e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/complexity/zipball/68ff824baeae169ec9f2137158ee529584553799
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/diff/zipball/c41e007b4b62af48218231d6c2275e4c9b975b2e
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/environment/zipball/8074dbcd93529b357029f5cc5058fd3e43666984
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/exporter/zipball/0735b90f4da94969541dac1da743446e276defa6
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/global-state/zipball/987bafff24ecc4c9ac418cab1145b96dd6e9cbd9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/lines-of-code/zipball/856e7f6a75a84e339195d48c556f23be2ebf75d0
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/202d0e344a580d7f7d04b3fafce6933e59dae906
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/24ed13d98130f0e7122df55d06c5c4942a577957
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/7e308268858ed6baedc8704a304727d20bc07c77
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/a95037b6d9e608ba092da1b23931e537cadc3c3c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/f5e568ba02fa5ba0ddd0f618391d5a9ea50b06d7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/0c7b06ff49e3d5072f057eb1fa59258bf287a748
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/php-timer/zipball/e2a2d67966e740530f4a3343fe2e030ffdc1161d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/phpunit/zipball/f2e26f52f80ef77832e359205f216eeac00e320c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/47e34210757a2f37a97dcd207d032e1b01e64c7a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/type/zipball/462699a16464c3944eefc02ebdd77882bd3925bf
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/version/zipball/c51fa83a5d8f43f1402e3f32a005e6262244ef17
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/spatie/phpunit-watcher/zipball/3b0e68596c70eba9bec99566b5e2199afb9f289d
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/console/zipball/732a9ca6cd9dfd940c639062d5edbde2f6727fb6
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/filesystem/zipball/d551b38811096d0be9c4691d406991b47c0c630a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/finder/zipball/fffe05569336549b20a1be64250b40516d6e8d06
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/options-resolver/zipball/b38026df55197f9e39a44f3215788edf83187b80
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-grapheme/zipball/380872130d3a5dd3ace2f4010d95125fde5d5c70
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-normalizer/zipball/3833d7255cc303546435cb650316bff708a1c75c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/process/zipball/2f8e1a6cdf590ca63715da4d3a7a3327404a523f
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/service-contracts/zipball/45112560a3ba2d715666a509a0bc9521d10b6c43
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/string/zipball/d50e862cb0a0e0886f73ca1f31b865efbb795003
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/yaml/zipball/24dd4de28d2e3988b311751ac49e684d783e2345
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/theseer/tokenizer/zipball/b7489ce515e168639d17feec34b8847c326b0b3c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/webmozarts/glob/zipball/8a2842112d6916e61e0e15e316465b611f3abc17
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/bXm4u0 /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

This PR improves code consistency by adding missing use function imports for built-in PHP functions used in the trimDecimalZeros method. The file already follows a pattern of explicitly importing all functions used, and these three were inadvertently omitted.

Key Changes:

Added use function imports for rtrim, str_contains, and str_ends_with functions that are used in the trimDecimalZeros method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Initial plan

ae4487e

Copilot AI assigned Copilot and samdark Jan 8, 2026

Copilot AI mentioned this pull request Jan 8, 2026

Trim decimals #156

Merged

Copilot started work on behalf of samdark January 8, 2026 20:48 View session

Add missing use function imports for rtrim, str_contains, and str_end…

056d34e

…s_with Co-authored-by: samdark <[email protected]>

Copilot AI changed the title ~~[WIP] WIP to address feedback on trim decimals PR~~ Add missing use function imports in NumericHelper Jan 8, 2026

Copilot AI requested a review from samdark January 8, 2026 20:56

Copilot finished work on behalf of samdark January 8, 2026 20:56

samdark marked this pull request as ready for review January 8, 2026 22:02

Copilot AI review requested due to automatic review settings January 8, 2026 22:02

Copilot started reviewing on behalf of samdark January 8, 2026 22:03 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

samdark merged commit b46f55b into trim-decimals Jan 8, 2026
30 checks passed

samdark deleted the copilot/sub-pr-156 branch January 8, 2026 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing use function imports in NumericHelper#157

Add missing use function imports in NumericHelper#157
samdark merged 2 commits intotrim-decimalsfrom
copilot/sub-pr-156

Copilot AI commented Jan 8, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Jan 8, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Jan 8, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 8, 2026 •

edited

Loading